Skip to content

Replace flag with kingpin and use promlog #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

Replace flag with kingpin and use promlog #420

merged 1 commit into from
Jun 9, 2023

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented May 24, 2023 •
edited
Loading

Proposed changes

  • Replaces flag with kigpin
  • Uses promlog and go-kit/log

Aligns with the most common implementation of exporters and among other things will allow us to use https://github.com/prometheus/exporter-toolkit for example in #231

Closes #227

@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests Pull requests that update tests labels May 24, 2023
@lucacome lucacome force-pushed the change/replace-flag branch 3 times, most recently from 325bbee to 416827e Compare May 24, 2023 23:52
@lucacome lucacome marked this pull request as ready for review May 25, 2023 00:06
@lucacome lucacome requested a review from a team as a code owner May 25, 2023 00:06
@lucacome lucacome added the change Pull requests that introduce a change label May 25, 2023
@lucacome lucacome force-pushed the change/replace-flag branch from 416827e to f1b02a8 Compare May 25, 2023 01:33
@lucacome lucacome self-assigned this May 25, 2023
@lucacome lucacome force-pushed the change/replace-flag branch from 1db0d9c to b2878b4 Compare May 30, 2023 02:09
@lucacome lucacome changed the title Replace flag with kingpin Replace flag with kingpin and use promlog May 30, 2023
@lucacome lucacome force-pushed the change/replace-flag branch from ed83e58 to aa306cd Compare June 9, 2023 23:01
@lucacome lucacome enabled auto-merge (squash) June 9, 2023 23:03
@lucacome lucacome merged commit 965d9e4 into main Jun 9, 2023
@lucacome lucacome deleted the change/replace-flag branch June 9, 2023 23:03
@lucacome lucacome mentioned this pull request Jun 9, 2023
Closed
6 tasks
@lucacome lucacome added enhancement Pull requests for new features/feature enhancements change Pull requests that introduce a change and removed change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements labels Jul 26, 2023
@lucacome lucacome mentioned this pull request Aug 30, 2023
Closed
lucacome added a commit that referenced this pull request Dec 21, 2023
@lucacome
Restore SCRAPE_URI env var
ee847f9 
This was removed in #420 by mistake
@lucacome lucacome mentioned this pull request Dec 21, 2023
Merged
lucacome added a commit that referenced this pull request Dec 27, 2023
@lucacome
Restore SCRAPE_URI env var
97f0c4c 
This was removed in #420 by mistake
lucacome added a commit that referenced this pull request Jan 8, 2024
@lucacome
Restore SCRAPE_URI env var (#586)
c47a53e 
This was removed in #420 by mistake
@lbdemv lbdemv mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

+1 more reviewer

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
change Pull requests that introduce a change dependencies Pull requests that update a dependency file tests Pull requests that update tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration for log level and format
3 participants
@lucacome @haywoodsh @jasonwilliams14